Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 579303003: dart2js: mirrors. Support Typedef.reflectedType. (Closed)

Created:
6 years, 3 months ago by floitsch
Modified:
6 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2js: mirrors. Support Typedef.reflectedType. BUG= http://dartbug.com/18938 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=40494

Patch Set 1 #

Patch Set 2 : Add test. Revert owner change. #

Patch Set 3 : Remove spurious field. #

Total comments: 4

Patch Set 4 : Add TODO back. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
A tests/lib/mirrors/typedef_reflected_type_test.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
6 years, 3 months ago (2014-09-19 10:05:31 UTC) #2
karlklose
Change to reflectType LGTM. https://codereview.chromium.org/579303003/diff/40001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (left): https://codereview.chromium.org/579303003/diff/40001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart#oldcode2535 sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2535: // TODO(ahe): Implement this method. ...
6 years, 3 months ago (2014-09-19 10:39:51 UTC) #3
floitsch
https://codereview.chromium.org/579303003/diff/40001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (left): https://codereview.chromium.org/579303003/diff/40001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart#oldcode2535 sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2535: // TODO(ahe): Implement this method. On 2014/09/19 10:39:51, karlklose ...
6 years, 3 months ago (2014-09-19 11:42:09 UTC) #4
floitsch
6 years, 3 months ago (2014-09-19 11:42:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 40494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698