Allow Windows network share paths for the script path and the package root.

Allow Windows network share paths for the script path and the package root.

BUG=dartbug.com/14577
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29878

[Bill Hesse, 2013-11-04 15:58:34]

This change loses one small bit of functionality: Accepting a script path on
Windows that is an absolute path without a drive letter or share name, since
Uri.file and Uri.toFilePath don't accept it.  We can add it back in, if you
want.

[Søren Gjesse, 2013-11-04 16:15:58]

LGTM - nice cleanup.

https://codereview.chromium.org/57923004/diff/1/runtime/bin/extensions.cc
File runtime/bin/extensions.cc (right):

https://codereview.chromium.org/57923004/diff/1/runtime/bin/extensions.cc#new...
runtime/bin/extensions.cc:19: Dart_Handle Extensions::LoadExtension(const char*
extension_url,
With the test for both / and \ below the name of this argument should not be
extension_url but extension_path.

https://codereview.chromium.org/57923004/diff/1/tests/standalone/io/test_exte...
File tests/standalone/io/test_extension_test.dart (right):

https://codereview.chromium.org/57923004/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_test.dart:59: if (result.exitCode != 0) {
Debug print.

[Bill Hesse, 2013-11-05 08:11:06]

Committed patchset #1 manually as r29878 (presubmit successful).

[Bill Hesse, 2013-11-05 08:52:23]

https://codereview.chromium.org/57923004/diff/1/tests/standalone/io/test_exte...
File tests/standalone/io/test_extension_test.dart (right):

https://codereview.chromium.org/57923004/diff/1/tests/standalone/io/test_exte...
tests/standalone/io/test_extension_test.dart:59: if (result.exitCode != 0) {
On 2013/11/04 16:15:58, Søren Gjesse wrote:
> Debug print.

This is not debug printing, but output of the subprocess stdout and stderr in
the case of a test failure, as we do with other subprocess tests.