Allow Windows network share paths for the script path and the package root.

runtime/bin/extensions.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/extensions.h"
 
 #include <stdio.h>
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/globals.h"
 #include "bin/dartutils.h"
 #include "bin/file.h"
 
 
 namespace dart {
 namespace bin {
 
 Dart_Handle Extensions::LoadExtension(const char* extension_url,

[Søren Gjesse, 2013/11/04 16:15:58]

With the test for both / and \ below the name of this argument should not be
extension_url but extension_path.

                                       Dart_Handle parent_library) {
   char* library_path = strdup(extension_url);
 
   if (library_path == NULL) {
     return Dart_NewApiError("Out of memory in LoadExtension");
   }
 
   // Extract the path and the extension name from the url.
   char* last_path_separator = strrchr(library_path, '/');
+  if (last_path_separator == NULL) {
+    last_path_separator = strrchr(library_path, '\\');
+  }
+  if (last_path_separator == NULL) {
+    free(library_path);
+    return Dart_NewApiError("Cannot find extension library directory");
+  }
   char* extension_name = last_path_separator + 1;
+
   *last_path_separator = '\0';  // Terminate library_path at last separator.
 
   void* library_handle = LoadExtensionLibrary(library_path, extension_name);
   if (library_handle == NULL) {
     free(library_path);
-    return Dart_NewApiError("cannot find extension library");
+    return Dart_NewApiError("Cannot find extension library");
   }
 
   const char* strings[] = { extension_name, "_Init", NULL };
   char* init_function_name = Concatenate(strings);
   typedef Dart_Handle (*InitFunctionType)(Dart_Handle import_map);
   InitFunctionType fn = reinterpret_cast<InitFunctionType>(
       ResolveSymbol(library_handle, init_function_name));
   free(init_function_name);
   free(library_path);
 
   if (fn == NULL) {
-    return Dart_NewApiError("cannot find initialization function in extension");
+    return Dart_NewApiError("Cannot find initialization function in extension");
   }
   return (*fn)(parent_library);
 }
 
 
 // Concatenates a NULL terminated array of strings.
 // The returned string must be freed.
 char* Extensions::Concatenate(const char** strings) {
   int size = 1;  // null termination.
   for (int i = 0; strings[i] != NULL; i++) {
     size += strlen(strings[i]);
   }
   char* result = reinterpret_cast<char*>(malloc(size));
   int index = 0;
   for (int i = 0; strings[i] != NULL; i++) {
     index += snprintf(result + index, size - index, "%s", strings[i]);
   }
   ASSERT(index == size - 1);
   ASSERT(result[size - 1] == '\0');
   return result;
 }
 
 }  // namespace bin
 }  // namespace dart