Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 578993002: Unify parsing of Firefox and Safari stack traces. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Unify parsing of Firefox and Safari stack traces. This releases stack_trace 1.1.0. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=40470

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -86 lines) Patch
M pkg/stack_trace/CHANGELOG.md View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/stack_trace/lib/src/frame.dart View 2 chunks +43 lines, -32 lines 0 comments Download
M pkg/stack_trace/lib/src/trace.dart View 1 3 chunks +26 lines, -35 lines 0 comments Download
M pkg/stack_trace/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 6 chunks +6 lines, -8 lines 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 3 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 3 months ago (2014-09-17 21:47:21 UTC) #1
Bob Nystrom
https://codereview.chromium.org/578993002/diff/1/pkg/stack_trace/lib/src/trace.dart File pkg/stack_trace/lib/src/trace.dart (right): https://codereview.chromium.org/578993002/diff/1/pkg/stack_trace/lib/src/trace.dart#newcode115 pkg/stack_trace/lib/src/trace.dart:115: // try { ?
6 years, 3 months ago (2014-09-18 19:12:03 UTC) #2
nweiz
Code review changes
6 years, 3 months ago (2014-09-18 19:53:45 UTC) #3
nweiz
https://codereview.chromium.org/578993002/diff/1/pkg/stack_trace/lib/src/trace.dart File pkg/stack_trace/lib/src/trace.dart (right): https://codereview.chromium.org/578993002/diff/1/pkg/stack_trace/lib/src/trace.dart#newcode115 pkg/stack_trace/lib/src/trace.dart:115: // try { On 2014/09/18 19:12:03, Bob Nystrom wrote: ...
6 years, 3 months ago (2014-09-18 19:54:04 UTC) #4
Bob Nystrom
LGTM!
6 years, 3 months ago (2014-09-18 21:57:23 UTC) #5
nweiz
6 years, 3 months ago (2014-09-18 22:20:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 40470 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698