Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: pkg/stack_trace/test/frame_test.dart

Issue 578993002: Unify parsing of Firefox and Safari stack traces. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/stack_trace/pubspec.yaml ('k') | pkg/stack_trace/test/trace_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/test/frame_test.dart
diff --git a/pkg/stack_trace/test/frame_test.dart b/pkg/stack_trace/test/frame_test.dart
index 1205d74840b826c463aaa4decd3fb14fd2486022..b132368ca20c91478ebe6b0fea886efc0747cfcc 100644
--- a/pkg/stack_trace/test/frame_test.dart
+++ b/pkg/stack_trace/test/frame_test.dart
@@ -210,7 +210,7 @@ void main() {
});
});
- group('.parseFirefox', () {
+ group('.parseFirefox/.parseSafari', () {
test('parses a simple stack frame correctly', () {
var frame = new Frame.parseFirefox(
".VW.call\$0@http://pub.dartlang.org/stuff.dart.js:560");
@@ -356,11 +356,9 @@ void main() {
expect(() => new Frame.parseFirefox('@dart:async/future.dart'),
throwsFormatException);
});
- });
- group('.parseSafari6_1', () {
test('parses a simple stack frame correctly', () {
- var frame = new Frame.parseSafari6_1(
+ var frame = new Frame.parseFirefox(
"foo\$bar@http://dartlang.org/foo/bar.dart:10:11");
expect(frame.uri, equals(Uri.parse("http://dartlang.org/foo/bar.dart")));
expect(frame.line, equals(10));
@@ -369,7 +367,7 @@ void main() {
});
test('parses an anonymous stack frame correctly', () {
- var frame = new Frame.parseSafari6_1(
+ var frame = new Frame.parseFirefox(
"http://dartlang.org/foo/bar.dart:10:11");
expect(frame.uri, equals(Uri.parse("http://dartlang.org/foo/bar.dart")));
expect(frame.line, equals(10));
@@ -378,7 +376,7 @@ void main() {
});
test('parses a stack frame with no line correctly', () {
- var frame = new Frame.parseSafari6_1(
+ var frame = new Frame.parseFirefox(
"foo\$bar@http://dartlang.org/foo/bar.dart::11");
expect(frame.uri, equals(Uri.parse("http://dartlang.org/foo/bar.dart")));
expect(frame.line, isNull);
@@ -387,7 +385,7 @@ void main() {
});
test('parses a stack frame with no column correctly', () {
- var frame = new Frame.parseSafari6_1(
+ var frame = new Frame.parseFirefox(
"foo\$bar@http://dartlang.org/foo/bar.dart:10:");
expect(frame.uri, equals(Uri.parse("http://dartlang.org/foo/bar.dart")));
expect(frame.line, equals(10));
@@ -396,7 +394,7 @@ void main() {
});
test('parses a stack frame with no line or column correctly', () {
- var frame = new Frame.parseSafari6_1(
+ var frame = new Frame.parseFirefox(
"foo\$bar@http://dartlang.org/foo/bar.dart:10:11");
expect(frame.uri, equals(Uri.parse("http://dartlang.org/foo/bar.dart")));
expect(frame.line, equals(10));
« no previous file with comments | « pkg/stack_trace/pubspec.yaml ('k') | pkg/stack_trace/test/trace_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698