Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 575503002: When inlining imports from head, put them inside a hidden div (Closed)

Created:
6 years, 3 months ago by jakemac
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

update allPhases tests make everything get inlined inside a hidden div to prevent FOUC only check for FOUC in entry point BUG= http://dartbug.com/20943 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=40320

Patch Set 1 #

Total comments: 4

Patch Set 2 : move/clarify comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -35 lines) Patch
M pkg/polymer/lib/src/build/import_inliner.dart View 6 chunks +20 lines, -5 lines 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/all_phases_test.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/polymer/test/build/import_inliner_test.dart View 1 29 chunks +114 lines, -12 lines 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 1 chunk +55 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jakemac
6 years, 3 months ago (2014-09-15 17:20:20 UTC) #2
Siggi Cherem (dart-lang)
nice, lgtm https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart File pkg/polymer/test/build/import_inliner_test.dart (right): https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart#newcode920 pkg/polymer/test/build/import_inliner_test.dart:920: '<div hidden="">' // NOTE: Parser injects the ...
6 years, 3 months ago (2014-09-15 18:04:32 UTC) #3
jakemac
https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart File pkg/polymer/test/build/import_inliner_test.dart (right): https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart#newcode920 pkg/polymer/test/build/import_inliner_test.dart:920: '<div hidden="">' // NOTE: Parser injects the first import ...
6 years, 3 months ago (2014-09-15 18:34:04 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart File pkg/polymer/test/build/import_inliner_test.dart (right): https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart#newcode920 pkg/polymer/test/build/import_inliner_test.dart:920: '<div hidden="">' // NOTE: Parser injects the first ...
6 years, 3 months ago (2014-09-15 19:18:16 UTC) #5
jakemac
https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart File pkg/polymer/test/build/import_inliner_test.dart (right): https://codereview.chromium.org/575503002/diff/1/pkg/polymer/test/build/import_inliner_test.dart#newcode920 pkg/polymer/test/build/import_inliner_test.dart:920: '<div hidden="">' // NOTE: Parser injects the first import ...
6 years, 3 months ago (2014-09-15 20:47:34 UTC) #6
jakemac
6 years, 3 months ago (2014-09-16 15:41:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 40320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698