Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1940)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/polymer/test/build/linter_test.dart

Issue 575503002: When inlining imports from head, put them inside a hidden div (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: move/clarify comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/test/build/import_inliner_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/linter_test.dart
diff --git a/pkg/polymer/test/build/linter_test.dart b/pkg/polymer/test/build/linter_test.dart
index 6d5b883c8126588c54e0cb4f8c536caf6af464c3..7a784f584e564f44e594bad89b6076e847eaa805 100644
--- a/pkg/polymer/test/build/linter_test.dart
+++ b/pkg/polymer/test/build/linter_test.dart
@@ -641,64 +641,104 @@ void main() {
]);
_testLinter('FOUC warning works', {
- 'a|lib/a.html': '''
+ 'a|web/a.html': '''
+ <!DOCTYPE html>
<html><body>
<link rel="import" href="../../packages/polymer/polymer.html">
<polymer-element name="my-element" noscript></polymer-element>
<my-element>hello!</my-element>
+ <script type="application/dart">
+ export "package:polymer/init.dart";
+ </script>
</body></html>
''',
- 'a|lib/b.html': '''
+ 'a|web/b.html': '''
+ <!DOCTYPE html>
<html><body>
<link rel="import" href="../../packages/polymer/polymer.html">
<polymer-element name="my-element" noscript></polymer-element>
<div><my-element>hello!</my-element></div>
+ <script type="application/dart">
+ export "package:polymer/init.dart";
+ </script>
</body></html>
''',
- 'a|lib/c.html': '''
+ 'a|web/c.html': '''
+ <!DOCTYPE html>
<html unresolved><body>
<link rel="import" href="../../packages/polymer/polymer.html">
<polymer-element name="my-element" noscript></polymer-element>
<my-element>hello!</my-element>
+ <script type="application/dart">
+ export "package:polymer/init.dart";
+ </script>
</body></html>
'''
}, [
- 'warning: ${POSSIBLE_FUOC.snippet} (lib/a.html 3 14)',
- 'warning: ${POSSIBLE_FUOC.snippet} (lib/b.html 3 19)',
- 'warning: ${POSSIBLE_FUOC.snippet} (lib/c.html 3 14)',
+ 'warning: ${POSSIBLE_FUOC.snippet} (web/a.html 4 14)',
+ 'warning: ${POSSIBLE_FUOC.snippet} (web/b.html 4 19)',
+ 'warning: ${POSSIBLE_FUOC.snippet} (web/c.html 4 14)',
]);
_testLinter('FOUC, no false positives.', {
- 'a|lib/a.html': '''
- <html><body><div unresolved>
- <link rel="import" href="../../packages/polymer/polymer.html">
- <polymer-element name="my-element" noscript></polymer-element>
- <my-element>hello!</my-element>
- </div></body></html>
+ // Parent has unresolved attribute.
+ 'a|web/a.html': '''
+ <!DOCTYPE html>
+ <html><body>
+ <div unresolved>
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <my-element>hello!</my-element>
+ </div>
+ <script type="application/dart">
+ export "package:polymer/init.dart";
+ </script>
+ </body></html>
''',
- 'a|lib/b.html': '''
+ // Body has unresolved attribute.
+ 'a|web/b.html': '''
+ <!DOCTYPE html>
<html><body unresolved>
<link rel="import" href="../../packages/polymer/polymer.html">
<polymer-element name="my-element" noscript></polymer-element>
<my-element>hello!</my-element>
+ <script type="application/dart">
+ export "package:polymer/init.dart";
+ </script>
</body></html>
''',
- 'a|lib/c.html': '''
+ // Inside polymer-element tags its fine.
+ 'a|web/c.html': '''
+ <!DOCTYPE html>
<html><body>
<link rel="import" href="../../packages/polymer/polymer.html">
<polymer-element name="my-element" noscript></polymer-element>
<polymer-element name="foo-element">
<template><my-element>hello!</my-element></template>
</polymer-element>
+ <script type="application/dart">
+ export "package:polymer/init.dart";
+ </script>
</body></html>
''',
- 'a|lib/d.html': '''
+ // Empty custom elements are fine.
+ 'a|web/d.html': '''
+ <!DOCTYPE html>
<html><body>
<link rel="import" href="../../packages/polymer/polymer.html">
<polymer-element name="my-element" noscript></polymer-element>
<my-element></my-element>
+ <script type="application/dart">
+ export "package:polymer/init.dart";
+ </script>
</body></html>
''',
+ // Entry points only!
+ 'a|lib/a.html': '''
+ <link rel="import" href="../../packages/polymer/polymer.html">
+ <polymer-element name="my-element" noscript></polymer-element>
+ <my-element>hello!</my-element>
+ ''',
}, []);
});
« no previous file with comments | « pkg/polymer/test/build/import_inliner_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698