Issue 572913002: Revert r40306 because of crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 572913002: Revert r40306 because of crash. (Closed)

Created:
6 years, 3 months ago by Florian Schneider

Modified:
6 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r40306 because of crash. TBR=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40312

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+273 lines, -105 lines)			Patch
M	runtime/tests/vm/dart/inline_stack_frame_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/deferred_objects.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	3 chunks	+4 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+2 lines, -28 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	4 chunks	+35 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	4 chunks	+32 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	4 chunks	+32 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	4 chunks	+36 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	4 chunks	+32 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+16 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+16 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+16 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+16 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+16 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Committed patchset #1 (id:1) manually as r40312 (presubmit successful).

6 years, 3 months ago (2014-09-16 12:14:50 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages