Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/tests/vm/dart/inline_stack_frame_test.dart

Issue 572913002: Revert r40306 because of crash. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/deferred_objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tests/vm/dart/inline_stack_frame_test.dart
===================================================================
--- runtime/tests/vm/dart/inline_stack_frame_test.dart (revision 40311)
+++ runtime/tests/vm/dart/inline_stack_frame_test.dart (working copy)
@@ -14,6 +14,9 @@
// method in the invocation chain. The test is run during warmup to ensure
// unoptimized code produces the correct result and is then run
// in a loop to ensure optimization kicks in and some inlining is done.
+// Note: it appears that functions which have a throw are not inlined (func4)
+// and functions that have try/catch in them are not optimized (func1).
+// func2 is not inlined as func1 has not been optimized.
class Test {
String func1(var k) {
« no previous file with comments | « no previous file | runtime/vm/deferred_objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698