Complete latest spec changes regarding malformed types (see issue 14006).

Complete latest spec changes regarding malformed types (see issue 14006).
Update language tests and mark them as failing in dart2js as appropriate.
Mark a few co19 tests as failing.
Mark a dart2js test as failing due to unresolved types.

Unfortunately, https://codereview.chromium.org/53583003/ was uncomplete and
missed a few mappings of malformed types to dynamic.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29924

[regis, 2013-11-05 02:46:11]

Vijay, Kasper, Bob,

The change submitted last week that was supposed to detect malformed types
missed a few. Also, catching a malformed type is supposed to throw a TypeError
now. This was not working either.
 
I will try to commit this change on Wednesday morning. It may turn some build
bots red, but it will be due to unresolved types being referenced. So this
should be easy to fix (typo, missing import, etc...)

Remember that you can also run with --error_on_bad_type to detect such bad types
that may be declared, but not used.

Thanks,
Regis

[kasperl, 2013-11-05 07:24:28]

Johnni, could you take a quick look to make sure the two implementations are in
sync?

[Johnni Winther, 2013-11-05 07:30:53]

On 2013/11/05 07:24:28, kasperl wrote:
> Johnni, could you take a quick look to make sure the two implementations are
in
> sync?

The tests indicate that we implement the same interpretation.

[hausner, 2013-11-05 17:45:16]

LGTM with a couple of nits/suggestions.

https://codereview.chromium.org/57133004/diff/140001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/57133004/diff/140001/runtime/vm/object.cc#new...
runtime/vm/object.cc:11443: // Caller must handle malformed types and not call
this kIsSubtypeOf test.
the comment and the assertion mention different test_kind constants, which is a
bit confusing.

https://codereview.chromium.org/57133004/diff/140001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/57133004/diff/140001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:6935: const bool throw_on_bad_type =
exception_param.type->IsMalformed() ||
const bool is_bad_type = ... ?

[regis, 2013-11-05 18:05:11]

Thanks!

Dart2js implemented the same change overnight. So I am still in the process of
merging the tests and status files.

https://codereview.chromium.org/57133004/diff/140001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/57133004/diff/140001/runtime/vm/object.cc#new...
runtime/vm/object.cc:11443: // Caller must handle malformed types and not call
this kIsSubtypeOf test.
On 2013/11/05 17:45:17, hausner wrote:
> the comment and the assertion mention different test_kind constants, which is
a
> bit confusing. 

I rewrote the comment.

[regis, 2013-11-05 18:46:25]

Committed patchset #5 manually as r29924 (presubmit successful).