runtime/vm/code_generator.cc - Issue 57133004: Complete latest spec changes regarding malformed types (see issue 14006).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator.cc

Issue 57133004: Complete latest spec changes regarding malformed types (see issue 14006). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator.cc

===================================================================

--- runtime/vm/code_generator.cc (revision 29923)

+++ runtime/vm/code_generator.cc (working copy)

@@ -545,6 +545,9 @@

const SubtypeTestCache& cache =

SubtypeTestCache::CheckedHandle(arguments.ArgAt(4));

ASSERT(type.IsFinalized());

+ ASSERT(!type.IsDynamicType()); // No need to check assignment.

+ ASSERT(!type.IsMalformed()); // Already checked in code generator.

+ ASSERT(!type.IsMalbounded()); // Already checked in code generator.

Error& bound_error = Error::Handle();

const Bool& result =

Bool::Get(instance.IsInstanceOf(type,

« no previous file with comments | « no previous file | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »