Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 569743003: update error handling to send response with stack trace (Closed)

Created:
6 years, 3 months ago by danrubel
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

update error handling to send response with stack trace BUG=dartbug.com/20893 R=brianwilkerson@google.com, paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=40237

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -90 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestError.java View 7 chunks +19 lines, -18 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 16 chunks +50 lines, -36 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 6 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +6 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
6 years, 3 months ago (2014-09-12 19:21:58 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-12 19:41:55 UTC) #3
Paul Berry
lgtm
6 years, 3 months ago (2014-09-12 20:36:08 UTC) #4
danrubel
6 years, 3 months ago (2014-09-15 12:30:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40237 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698