Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2105)

Unified Diff: pkg/analysis_server/test/socket_server_test.dart

Issue 569743003: update error handling to send response with stack trace (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/protocol_test.dart ('k') | pkg/analysis_server/tool/spec/spec_input.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/socket_server_test.dart
diff --git a/pkg/analysis_server/test/socket_server_test.dart b/pkg/analysis_server/test/socket_server_test.dart
index 288d33f35e779eb955f5069c7274b5d6eea7459c..081d5271a68d636e3fa1e67ca1bd67bb4615d019 100644
--- a/pkg/analysis_server/test/socket_server_test.dart
+++ b/pkg/analysis_server/test/socket_server_test.dart
@@ -69,6 +69,8 @@ class SocketServerTest {
SocketServer server = new SocketServer(DirectoryBasedDartSdk.defaultSdk);
MockServerChannel channel = new MockServerChannel();
server.createAnalysisServer(channel);
+ channel.expectMsgCount(notificationCount: 1);
+ expect(channel.notificationsReceived[0].event, SERVER_CONNECTED);
_MockRequestHandler handler = new _MockRequestHandler(false);
server.analysisServer.handlers = [handler];
var request = new ServerGetVersionParams().toRequest('0');
@@ -76,8 +78,10 @@ class SocketServerTest {
expect(response.id, equals('0'));
expect(response.error, isNotNull);
expect(response.error.code, equals(RequestErrorCode.SERVER_ERROR));
- channel.expectMsgCount(responseCount: 1, notificationCount: 2);
- expect(channel.notificationsReceived[1].event, SERVER_ERROR);
+ expect(response.error.message, equals('mock request exception'));
+ expect(response.error.stackTrace, isNotNull);
+ expect(response.error.stackTrace, isNot(isEmpty));
+ channel.expectMsgCount(responseCount: 1, notificationCount: 1);
});
}
« no previous file with comments | « pkg/analysis_server/test/protocol_test.dart ('k') | pkg/analysis_server/tool/spec/spec_input.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698