Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 565643002: Refactor emitting of deoptimization descriptors for calls. (Closed)

Created:
6 years, 3 months ago by Florian Schneider
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Refactor emitting of deoptimization descriptors for calls. Instead of emitting the descriptor in EmitNativeCode, the instruction prologue now emits the descriptor automatically. To do that all instructions that need such a descriptor have CanBecomeDeoptimizationTarget set to true. I moved the duplicated for TargetEntryInstr::EmitNativeCode to intermediate_language.cc. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -119 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 3 chunks +19 lines, -16 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
6 years, 3 months ago (2014-09-11 13:15:20 UTC) #2
Vyacheslav Egorov (Google)
lgtm
6 years, 3 months ago (2014-09-11 13:30:13 UTC) #3
Florian Schneider
6 years, 3 months ago (2014-09-11 13:54:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40150 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698