Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: runtime/vm/intermediate_language.h

Issue 565643002: Refactor emitting of deoptimization descriptors for calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 40101)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -2498,6 +2498,12 @@
virtual bool CanDeoptimize() const { return true; }
+ virtual bool CanBecomeDeoptimizationTarget() const {
+ // AssertAssignable instructions that are specialized by the optimizer
+ // (e.g. replaced with CheckClass) need a deoptimization descriptor before.
+ return true;
+ }
+
virtual Definition* Canonicalize(FlowGraph* flow_graph);
virtual bool AllowsCSE() const { return true; }
@@ -2665,6 +2671,12 @@
virtual bool CanDeoptimize() const { return true; }
+ virtual bool CanBecomeDeoptimizationTarget() const {
+ // Instance calls that are specialized by the optimizer need a
+ // deoptimization descriptor before the call.
+ return true;
+ }
+
virtual EffectSet Effects() const { return EffectSet::All(); }
virtual bool MayThrow() const { return true; }
@@ -3137,6 +3149,12 @@
virtual bool CanDeoptimize() const { return true; }
+ virtual bool CanBecomeDeoptimizationTarget() const {
+ // Static calls that are specialized by the optimizer (e.g. sqrt) need a
+ // deoptimization descriptor before the call.
+ return true;
+ }
+
virtual EffectSet Effects() const { return EffectSet::All(); }
void set_result_cid(intptr_t value) { result_cid_ = value; }
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698