Do not include pub tests (and generated_pub tests) in the input for creating the sdk.

Do not include pub tests (and generated_pub tests) in the input for creating the sdk.

xcode does not like list of files that are longer than a certain limit (including the full path from where you run)

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40144

[ricow1, 2014-09-11 12:08:49]

ricow@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2014-09-11 12:47:31]

LGTM.

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp
File create_sdk.gyp (right):

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp#newcode23
create_sdk.gyp:23: # This is neccessary because we have all the pub test files
inside
Extend comment to explain what the regexp does?

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp#newcode24
create_sdk.gyp:24: # the pub directory instead of in tests/pub. xcode can only
handle
xcode -> Xcode

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp#newcode26
create_sdk.gyp:26: # lengt of the path from where you run).
lengt -> length

[ricow1, 2014-09-11 12:49:38]

+bob fyi

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp
File create_sdk.gyp (right):

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp#newcode23
create_sdk.gyp:23: # This is neccessary because we have all the pub test files
inside
On 2014/09/11 12:47:30, kasperl wrote:
> Extend comment to explain what the regexp does?

Done.

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp#newcode24
create_sdk.gyp:24: # the pub directory instead of in tests/pub. xcode can only
handle
On 2014/09/11 12:47:30, kasperl wrote:
> xcode -> Xcode

Done.

https://codereview.chromium.org/564753002/diff/80001/create_sdk.gyp#newcode26
create_sdk.gyp:26: # lengt of the path from where you run).
On 2014/09/11 12:47:30, kasperl wrote:
> lengt -> length

Done.

[ricow1, 2014-09-11 12:49:54]

Committed patchset #6 (id:100001) manually as r40144 (presubmit successful).

[Bob Nystrom, 2014-09-12 21:25:24]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2014-09-12 21:25:25]

LGTM.

You could also omit *all* of the pub sources (except the few files in
pub/asset/). Since this already depends on the pub snapshot which in turn
depends on pub's source, the SDK itself shouldn't really depend on the sources
directly.