Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2136)

Unified Diff: create_sdk.gyp

Issue 564753002: Do not include pub tests (and generated_pub tests) in the input for creating the sdk. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: create_sdk.gyp
===================================================================
--- create_sdk.gyp (revision 40135)
+++ create_sdk.gyp (working copy)
@@ -20,7 +20,14 @@
{
'action_name': 'create_sdk_py',
'inputs': [
- '<!@(["python", "tools/list_files.py", "\\.dart$", "sdk/lib"])',
+ # This is neccessary because we have all the pub test files inside
+ # the pub directory instead of in tests/pub. Xcode can only handle
+ # a certain amount of files in one list (also depending on the
+ # length of the path from where you run). This regexp excludes
+ # pub/test and pub_generated/test
+ '<!@(["python", "tools/list_files.py",'
+ '"^(?!.*pub/test)(?!.*pub_generated/test).*dart$",'
+ '"sdk/lib"])',
'<!@(["python", "tools/list_files.py", "", '
'"sdk/lib/_internal/compiler/js_lib/preambles"])',
'<!@(["python", "tools/list_files.py", "", "sdk/bin"])',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698