Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 563043003: Don't crash when generating error messages with malformed strings. (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't crash when generating error messages with malformed strings. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40829

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M runtime/vm/dart_api_impl_test.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/unicode.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
A tests/corelib/throw_half_surrogate_pair_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
6 years, 3 months ago (2014-09-11 21:44:19 UTC) #2
siva
lgtm
6 years, 2 months ago (2014-09-26 20:13:03 UTC) #3
rmacnak
6 years, 2 months ago (2014-10-01 00:49:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40829 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698