runtime/vm/unicode.cc - Issue 563043003: Don't crash when generating error messages with malformed strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/unicode.cc

Issue 563043003: Don't crash when generating error messages with malformed strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/unicode.cc

diff --git a/runtime/vm/unicode.cc b/runtime/vm/unicode.cc

index 16e14e696cbeb10b2d50c2f59de4e1cb52e3e091..615e87b56127c64c6f0d72ebc05d5de8d55e0697 100644

--- a/runtime/vm/unicode.cc

+++ b/runtime/vm/unicode.cc

@@ -138,7 +138,6 @@ intptr_t Utf8::Length(const String& str) {

intptr_t Utf8::Encode(int32_t ch, char* dst) {

- ASSERT(!Utf16::IsSurrogate(ch));

static const int kMask = ~(1 << 6);

if (ch <= kMaxOneByteChar) {

dst[0] = ch;

« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | tests/corelib/throw_half_surrogate_pair_test.dart » ('j') | no next file with comments »