Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 560133003: Rollback https://codereview.chromium.org/575613002 (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rollback https://codereview.chromium.org/575613002 I'm sorry, but I'm going to rollback this change. We discussed this offline with Brian and decided that while it looks technically correct, it does not work well for our use cases, as well as probably for our users. R=paulberry@google.com, brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=19697 Committed: https://code.google.com/p/dart/source/detail?r=40324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -206 lines) Patch
M pkg/analysis_server/lib/src/search/element_references.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/hierarchy.dart View 3 chunks +10 lines, -22 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +28 lines, -117 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 5 chunks +16 lines, -64 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 3 months ago (2014-09-16 16:17:51 UTC) #1
Paul Berry
lgtm
6 years, 3 months ago (2014-09-16 16:24:42 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 40324 (presubmit successful).
6 years, 3 months ago (2014-09-16 16:31:57 UTC) #3
Brian Wilkerson
6 years, 3 months ago (2014-09-16 16:32:28 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698