Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 558893002: add code completion declared and return types (Closed)

Created:
6 years, 3 months ago by danrubel
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

add code completion declared and return types BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40087

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge and remove reference to analysis engine #

Messages

Total messages: 5 (1 generated)
danrubel
6 years, 3 months ago (2014-09-10 01:27:59 UTC) #2
scheglov
LGTM https://codereview.chromium.org/558893002/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java (right): https://codereview.chromium.org/558893002/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java#newcode16 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java:16: import com.google.dart.engine.element.Element; Don't reference Engine elements.
6 years, 3 months ago (2014-09-10 01:32:53 UTC) #3
danrubel
https://codereview.chromium.org/558893002/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java (right): https://codereview.chromium.org/558893002/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java#newcode16 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java:16: import com.google.dart.engine.element.Element; On 2014/09/10 01:32:53, scheglov wrote: > Don't ...
6 years, 3 months ago (2014-09-10 12:45:26 UTC) #4
danrubel
6 years, 3 months ago (2014-09-10 13:04:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40087 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698