Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

Issue 558893002: add code completion declared and return types (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge and remove reference to analysis engine Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
index bd26d711cb2f850169fea55918186d037c33df09..ad9b387cbb8b4d4aefd76d1840bcbf675fb249ee 100644
--- a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
@@ -102,11 +102,6 @@ class _InvocationElementVisitor extends GeneralizingElementVisitor<Future<bool>>
}
}
});
-
- element.importedLibraries.forEach((LibraryElement library) {
- modified = true;
- library.accept(new ClassElementSuggestionBuilder(request));
- });
return new Future.value(modified);
}
@@ -114,8 +109,7 @@ class _InvocationElementVisitor extends GeneralizingElementVisitor<Future<bool>>
Future<bool> visitVariableElement(VariableElement element) {
DartType type = element.type;
if (type != null) {
- Element typeElement = type.element;
- ClassElementSuggestionBuilder.suggestionsFor(request, typeElement);
+ ClassElementSuggestionBuilder.suggestionsFor(request, type.element);
}
return new Future.value(true);
}

Powered by Google App Engine
This is Rietveld 408576698