Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558703005: Do not navigate to vm-connect page upon disconnect (Closed)

Created:
6 years, 3 months ago by Cutch
Modified:
6 years, 3 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Visibility:
Public.

Description

Do not navigate to vm-connect page upon disconnect Also, prompt the user when they click a link when we hvae no connection BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=40262

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M runtime/bin/vmservice/observatory/lib/src/app/application.dart View 1 3 chunks +9 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/nav_bar.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
6 years, 3 months ago (2014-09-15 16:21:27 UTC) #2
turnidge
lgtm https://codereview.chromium.org/558703005/diff/1/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart File runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart (right): https://codereview.chromium.org/558703005/diff/1/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart#newcode40 runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart:40: url = makeLink('/vm-connect/'); Consider adding a notification.
6 years, 3 months ago (2014-09-15 16:24:48 UTC) #3
Cutch
https://codereview.chromium.org/558703005/diff/1/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart File runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart (right): https://codereview.chromium.org/558703005/diff/1/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart#newcode40 runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart:40: url = makeLink('/vm-connect/'); On 2014/09/15 16:24:48, turnidge wrote: > ...
6 years, 3 months ago (2014-09-15 18:11:20 UTC) #4
Cutch
6 years, 3 months ago (2014-09-15 18:20:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 40262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698