runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart - Issue 558703005: Do not navigate to vm-connect page upon disconnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart

Issue 558703005: Do not navigate to vm-connect page upon disconnect (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/app/application.dart ('k') | runtime/bin/vmservice/observatory/lib/src/elements/nav_bar.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart b/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart

index 04b6d84bbf7f69a13984f2e8497871bd914440dc..0d7705bdda54ebc9682efce359c32bbfb3d655f1 100644

--- a/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart

@@ -33,6 +33,10 @@ abstract class LocationManager extends Observable {

/// Go to a specific url.

void go(String url) {

if (_app.vm == null) {

+ if (!window.confirm('Connection with VM has been lost. '

+ 'Proceeding will lose current page.')) {

+ return;

+ }

url = makeLink('/vm-connect/');

}

_pushUrl(url);