Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 557413002: Merge chains of straight-line blocks. (Closed)

Created:
6 years, 3 months ago by Florian Schneider
Modified:
5 years, 10 months ago
Reviewers:
zerny-google
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Merge chains of straight-line blocks. This reduces the size of the graph after constant propagation and reduces the cost of later phases in the optimizer.

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : fixed assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M runtime/vm/flow_graph.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
zerny-google
lgtm https://codereview.chromium.org/557413002/diff/1/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/557413002/diff/1/runtime/vm/flow_graph.cc#newcode180 runtime/vm/flow_graph.cc:180: BitVector* merged = new(isolate()) BitVector(postorder().length()); BitVector takes a ...
6 years, 1 month ago (2014-11-19 11:32:34 UTC) #2
Florian Schneider
https://codereview.chromium.org/557413002/diff/1/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/557413002/diff/1/runtime/vm/flow_graph.cc#newcode180 runtime/vm/flow_graph.cc:180: BitVector* merged = new(isolate()) BitVector(postorder().length()); On 2014/11/19 11:32:34, zerny-google ...
6 years, 1 month ago (2014-11-19 12:19:36 UTC) #3
Florian Schneider
6 years ago (2014-12-01 12:41:01 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as r42038 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698