Merge chains of straight-line blocks.

runtime/vm/flow_graph.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph.h"
 
 #include "vm/bit_vector.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/intermediate_language.h"
 #include "vm/growable_array.h"
@@ skipping 157 matching lines @@
     reverse_postorder_.Add(postorder_[block_count - i - 1]);
   }
 
   // Block effects are using postorder numbering. Discard computed information.
   block_effects_ = NULL;
   loop_headers_ = NULL;
   loop_invariant_loads_ = NULL;
 }
 
 
+void FlowGraph::MergeBlocks() {
+  bool changed = false;
+  BitVector* merged = new(isolate()) BitVector(postorder().length());

[zerny-google, 2014/11/19 11:32:34]

BitVector takes a isolate as first argument after rebasing.

[Florian Schneider, 2014/11/19 12:19:35]

Done.

+  for (BlockIterator block_it = reverse_postorder_iterator();
+       !block_it.Done();
+       block_it.Advance()) {
+    BlockEntryInstr* block = block_it.Current();
+    if (block->IsGraphEntry()) continue;
+    if (merged->Contains(block->postorder_number())) continue;
+
+    Instruction* last = block->last_instruction();
+    BlockEntryInstr* successor = NULL;
+    while ((last->SuccessorCount() == 1) &&
+           (last->SuccessorAt(0)->PredecessorCount() == 1) &&
+           (block->try_index() == last->SuccessorAt(0)->try_index())) {
+      successor = last->SuccessorAt(0);
+      ASSERT(last->IsGoto());
+
+      // Remove environment uses and unlink goto and block entry.
+      successor->UnuseAllInputs();
+      last->previous()->LinkTo(successor->next());
+      last->UnuseAllInputs();
+
+      last = successor->last_instruction();
+      merged->Add(successor->postorder_number());
+      changed = true;
+      if (FLAG_trace_optimization) {
+        OS::Print("Merged blocks B%" Pd " and B%" Pd "\n",
+                  block->block_id(),
+                  successor->block_id());
+      }
+    }
+    // The new block inherits the block id of the last successor to maintain
+    // the order of phi inputs at its successors consistent with block ids.
+    if (successor != NULL) {
+      block->set_block_id(successor->block_id());
+    }
+  }
+  // Recompute block order after changes were made.
+  if (changed) DiscoverBlocks();
+}
+
+
 // Debugging code to verify the construction of use lists.
 static intptr_t MembershipCount(Value* use, Value* list) {
   intptr_t count = 0;
   while (list != NULL) {
     if (list == use) ++count;
     list = list->next_use();
   }
   return count;
 }
 
@@ skipping 1066 matching lines @@
 }
 
 
 bool BlockEffects::IsSideEffectFreePath(BlockEntryInstr* from,
                                         BlockEntryInstr* to) const {
   return available_at_[to->postorder_number()]->Contains(
       from->postorder_number());
 }
 
 }  // namespace dart