Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 554053002: Return a feedback for the INLINE_METHOD refactoring. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Return a feedback for the INLINE_METHOD refactoring. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 4 chunks +25 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-08 19:51:08 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-08 19:55:17 UTC) #2
scheglov
6 years, 3 months ago (2014-09-08 19:56:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698