Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 554053002: Return a feedback for the INLINE_METHOD refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/refactoring/inline_method.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library edit.domain; 5 library edit.domain;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/analysis_server.dart'; 9 import 'package:analysis_server/src/analysis_server.dart';
10 import 'package:analysis_server/src/constants.dart'; 10 import 'package:analysis_server/src/constants.dart';
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 feedback.lengths = refactoring.lengths; 322 feedback.lengths = refactoring.lengths;
323 } 323 }
324 if (refactoring is InlineLocalRefactoring) { 324 if (refactoring is InlineLocalRefactoring) {
325 InlineLocalRefactoring refactoring = this.refactoring; 325 InlineLocalRefactoring refactoring = this.refactoring;
326 if (!status.hasFatalError) { 326 if (!status.hasFatalError) {
327 feedback = new InlineLocalVariableFeedback( 327 feedback = new InlineLocalVariableFeedback(
328 refactoring.variableName, 328 refactoring.variableName,
329 refactoring.referenceCount); 329 refactoring.referenceCount);
330 } 330 }
331 } 331 }
332 if (refactoring is InlineMethodRefactoring) {
333 InlineMethodRefactoring refactoring = this.refactoring;
334 if (!status.hasFatalError) {
335 feedback = new InlineMethodFeedback(
336 refactoring.methodName,
337 refactoring.isDeclaration,
338 className: refactoring.className);
339 }
340 }
332 if (refactoring is RenameRefactoring) { 341 if (refactoring is RenameRefactoring) {
333 RenameRefactoring refactoring = this.refactoring; 342 RenameRefactoring refactoring = this.refactoring;
334 RenameFeedback feedback = this.feedback; 343 RenameFeedback feedback = this.feedback;
335 feedback.elementKindName = refactoring.elementKindName; 344 feedback.elementKindName = refactoring.elementKindName;
336 feedback.oldName = refactoring.oldName; 345 feedback.oldName = refactoring.oldName;
337 } 346 }
338 return initStatus; 347 return initStatus;
339 }); 348 });
340 } 349 }
341 350
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 } 404 }
396 if (refactoring is RenameRefactoring) { 405 if (refactoring is RenameRefactoring) {
397 RenameRefactoring renameRefactoring = refactoring; 406 RenameRefactoring renameRefactoring = refactoring;
398 RenameOptions renameOptions = params.options; 407 RenameOptions renameOptions = params.options;
399 renameRefactoring.newName = renameOptions.newName; 408 renameRefactoring.newName = renameOptions.newName;
400 return renameRefactoring.checkNewName(); 409 return renameRefactoring.checkNewName();
401 } 410 }
402 return new RefactoringStatus(); 411 return new RefactoringStatus();
403 } 412 }
404 } 413 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/refactoring/inline_method.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698