Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 551043002: VM: Remove unused IsClosureCall bit from IC data. (Closed)

Created:
6 years, 3 months ago by Florian Schneider
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Remove unused IsClosureCall bit from IC data. Since closure calls are now implemented in terms of instance calls (via .call and a dispatcher method), there is no need for a bit in the IC data tracking if a IC call may be a closure call. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39979

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -64 lines) Patch
M runtime/vm/code_generator.cc View 5 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +0 lines, -9 lines 1 comment Download
M runtime/vm/object.h View 3 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/stub_code.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
https://codereview.chromium.org/551043002/diff/1/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (left): https://codereview.chromium.org/551043002/diff/1/runtime/vm/flow_graph_compiler.cc#oldcode875 runtime/vm/flow_graph_compiler.cc:875: if (ic_data.IsClosureCall()) { This code has effectively become unreachable, ...
6 years, 3 months ago (2014-09-08 16:17:17 UTC) #2
Vyacheslav Egorov (Google)
lgtm
6 years, 3 months ago (2014-09-08 17:01:23 UTC) #3
Florian Schneider
6 years, 3 months ago (2014-09-08 17:11:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r39979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698