Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: runtime/vm/code_generator.cc

Issue 551043002: VM: Remove unused IsClosureCall bit from IC data. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 39965)
+++ runtime/vm/code_generator.cc (working copy)
@@ -706,7 +706,6 @@
const Class& receiver_class,
const String& target_name,
const Array& arguments_descriptor,
- const ICData& ic_data,
Function* result) {
// 1. Check if there is a getter with the same name.
const String& getter_name = String::Handle(Field::GetterName(target_name));
@@ -752,7 +751,6 @@
receiver_class,
target_name,
args_descriptor,
- ic_data,
&result)) {
ArgumentsDescriptor desc(args_descriptor);
const Function& target_function =
@@ -787,7 +785,6 @@
String::Handle(ic_data.target_name()).ToCString(),
receiver.ToCString());
}
- ic_data.SetIsClosureCall();
target_function = InlineCacheMissHelper(receiver, ic_data);
}
ASSERT(!target_function.IsNull());
@@ -989,7 +986,6 @@
name,
args_desc));
if (target_function.IsNull()) {
- ic_data.SetIsClosureCall();
target_function = InlineCacheMissHelper(receiver, ic_data);
}
@@ -1258,12 +1254,11 @@
StackFrame* frame = iterator.NextFrame();
ASSERT(frame != NULL);
OS::PrintErr("IC call @%#" Px ": ICData: %p cnt:%" Pd " nchecks: %" Pd
- " %s %s\n",
+ " %s\n",
frame->pc(),
ic_data.raw(),
function.usage_counter(),
ic_data.NumberOfChecks(),
- ic_data.IsClosureCall() ? "closure" : "",
function.ToFullyQualifiedCString());
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698