Use the VM to detect when a precompiled executable is out-of-date.

Use the VM to detect when a precompiled executable is out-of-date.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39938

[Bob Nystrom, 2014-09-05 21:37:00]

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:167: // TODO(nweiz): Use the VM to
check this when issue 20802 is fixed.
If you aren't writing this file anymore, why check it here?

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/executable.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/executable.dart:165: return
Process.start(Platform.executable, vmArgs).then((process) {
await?

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/utils.dart:11: @MirrorsUsed(targets: ['pub.io',
'test_pub'])
Is this so libraryPath() works? Should document that here.

[nweiz, 2014-09-05 22:10:51]

Code review changes

[nweiz, 2014-09-05 22:10:57]

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:167: // TODO(nweiz): Use the VM to
check this when issue 20802 is fixed.
On 2014/09/05 21:37:00, Bob Nystrom wrote:
> If you aren't writing this file anymore, why check it here?

We are writing to it. For dependency executables, we write the file when we
compile and we check it on future "pub get"s to know when to recompile, since
the VM doesn't expose any way to *just* check if a snapshot is up-to-date
without running it.

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/executable.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/executable.dart:165: return
Process.start(Platform.executable, vmArgs).then((process) {
On 2014/09/05 21:37:00, Bob Nystrom wrote:
> await?

Pretty sure this isn't an async-safe file.

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/utils.dart:11: @MirrorsUsed(targets: ['pub.io',
'test_pub'])
On 2014/09/05 21:37:00, Bob Nystrom wrote:
> Is this so libraryPath() works? Should document that here.

Done.

[Bob Nystrom, 2014-09-05 22:25:54]

lgtm

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/executable.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/executable.dart:165: return
Process.start(Platform.executable, vmArgs).then((process) {
On 2014/09/05 22:10:57, nweiz wrote:
> On 2014/09/05 21:37:00, Bob Nystrom wrote:
> > await?
> 
> Pretty sure this isn't an async-safe file.

It is. When you rebase against latest, you'll see it's using some async stuff
already. :)

[nweiz, 2014-09-05 23:24:57]

Code review changes

[nweiz, 2014-09-05 23:25:01]

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/executable.dart (right):

https://codereview.chromium.org/548603002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/executable.dart:165: return
Process.start(Platform.executable, vmArgs).then((process) {
On 2014/09/05 22:25:54, Bob Nystrom wrote:
> On 2014/09/05 22:10:57, nweiz wrote:
> > On 2014/09/05 21:37:00, Bob Nystrom wrote:
> > > await?
> > 
> > Pretty sure this isn't an async-safe file.
> 
> It is. When you rebase against latest, you'll see it's using some async stuff
> already. :)

Done.

[nweiz, 2014-09-05 23:25:19]

Committed patchset #3 (id:40001) manually as 39938 (presubmit successful).