Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: sdk/lib/_internal/pub/lib/src/global_packages.dart

Issue 548603002: Use the VM to detect when a precompiled executable is out-of-date. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/executable.dart ('k') | sdk/lib/_internal/pub/lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/global_packages.dart
diff --git a/sdk/lib/_internal/pub/lib/src/global_packages.dart b/sdk/lib/_internal/pub/lib/src/global_packages.dart
index be8614801fb980f1959bc1c54ecccaeb934b0381..6f3da60e58ea6e0c61a438ec5becfae227b293b9 100644
--- a/sdk/lib/_internal/pub/lib/src/global_packages.dart
+++ b/sdk/lib/_internal/pub/lib/src/global_packages.dart
@@ -18,9 +18,7 @@ import 'lock_file.dart';
import 'log.dart' as log;
import 'package.dart';
import 'pubspec.dart';
-import 'package_graph.dart';
import 'system_cache.dart';
-import 'sdk.dart' as sdk;
import 'solver/version_solver.dart';
import 'source/cached.dart';
import 'source/git.dart';
@@ -149,9 +147,7 @@ class GlobalPackages {
Future _precompileExecutables(Entrypoint entrypoint, String package) {
return log.progress("Precompiling executables", () {
var binDir = p.join(_directory, package, 'bin');
- var sdkVersionPath = p.join(binDir, 'sdk-version');
cleanDir(binDir);
- writeTextFile(sdkVersionPath, "${sdk.version}\n");
return AssetEnvironment.create(entrypoint, BarbackMode.RELEASE,
useDart2JS: false).then((environment) {
@@ -314,18 +310,14 @@ class GlobalPackages {
log.verbosity = log.Verbosity.WARNING;
}
- return syncFuture(() {
- var sdkVersionPath = p.join(binDir, 'sdk-version');
- var snapshotVersion = readTextFile(sdkVersionPath);
- if (snapshotVersion == "${sdk.version}\n") return null;
- log.fine("$package:$executable was compiled with Dart "
- "${snapshotVersion.trim()} and needs to be recompiled.");
-
+ var snapshotPath = p.join(binDir, '$executable.dart.snapshot');
+ return exe.runSnapshot(snapshotPath, args, recompile: () {
+ log.fine("$package:$executable is out of date and needs to be "
+ "recompiled.");
return find(package)
.then((entrypoint) => entrypoint.loadPackageGraph())
.then((graph) => _precompileExecutables(graph.entrypoint, package));
- }).then((_) =>
- exe.runSnapshot(p.join(binDir, '$executable.dart.snapshot'), args));
+ });
}
/// Gets the path to the lock file for an activated cached package with
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/executable.dart ('k') | sdk/lib/_internal/pub/lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698