First end-to-end capability in analyzer2dart.

First end-to-end capability in analyzer2dart.

BUG=
R=brianwilkerson@google.com, paulberry@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40030

[Johnni Winther, 2014-09-08 11:47:28]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Brian Wilkerson, 2014-09-08 13:47:08]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2014-09-08 13:47:09]

LGTM

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/co...
File pkg/analyzer2dart/lib/src/converted_world.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/co...
pkg/analyzer2dart/lib/src/converted_world.dart:49: (analyzer.ExecutableElement
analyzerElement, AstNode node) {
Is this normal formatting? It looks strange to have the function body
un-indented from the parameter list. (Just trying to learn Dart coding style.)

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
File pkg/analyzer2dart/lib/src/element_converter.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
pkg/analyzer2dart/lib/src/element_converter.dart:38: if (input is
analyzer.FunctionElement) {
In case you didn't know, there is an ElementVisitor that might be a cleaner way
to implement this dispatch than a sequence of 'is' checks. Your call.

[sigurdm, 2014-09-08 14:07:16]

lgtm

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
File pkg/analyzer2dart/lib/src/dart_backend.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:15: DartOutputter outputter = new
DartOutputter(new Listener(), driver.outputProvider);
Long line

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:27: );
I think this `);` should go to previous line.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:44: void reportError(Spannable node,
MessageKind errorCode, [Map arguments = const {}]) {
Long line (several in this file)

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
File pkg/analyzer2dart/lib/src/element_converter.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
pkg/analyzer2dart/lib/src/element_converter.dart:48: class ElementY extends
dart2js.Element {
Document

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
pkg/analyzer2dart/lib/src/element_converter.dart:337: class
TopLevelFunctionElementY extends ElementY implements dart2js.FunctionElement {
long line

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/tr...
File pkg/analyzer2dart/lib/src/tree_shaker.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:26: 
Double newline

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/test/end2e...
File pkg/analyzer2dart/test/end2end_test.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/test/end2e...
pkg/analyzer2dart/test/end2end_test.dart:123: print('input:\n$input');
Debugging prints?

[Paul Berry, 2014-09-08 16:15:01]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-09-08 16:15:03]

lgtm

[Johnni Winther, 2014-09-09 14:21:27]

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/co...
File pkg/analyzer2dart/lib/src/converted_world.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/co...
pkg/analyzer2dart/lib/src/converted_world.dart:49: (analyzer.ExecutableElement
analyzerElement, AstNode node) {
On 2014/09/08 13:47:08, Brian Wilkerson wrote:
> Is this normal formatting? It looks strange to have the function body
> un-indented from the parameter list. (Just trying to learn Dart coding style.)

The body of a passed function expression is indented by 2 spaces from the
call-site. A call split over several line is indented by 4 spaces. These two
conflict visually here making the parameters of the function expression more
indented that the body.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
File pkg/analyzer2dart/lib/src/dart_backend.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:15: DartOutputter outputter = new
DartOutputter(new Listener(), driver.outputProvider);
On 2014/09/08 14:07:15, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:27: );
On 2014/09/08 14:07:15, sigurdm wrote:
> I think this `);` should go to previous line.

Done.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:44: void reportError(Spannable node,
MessageKind errorCode, [Map arguments = const {}]) {
On 2014/09/08 14:07:15, sigurdm wrote:
> Long line (several in this file)

Quick fix!! Done.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
File pkg/analyzer2dart/lib/src/element_converter.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
pkg/analyzer2dart/lib/src/element_converter.dart:38: if (input is
analyzer.FunctionElement) {
On 2014/09/08 13:47:09, Brian Wilkerson wrote:
> In case you didn't know, there is an ElementVisitor that might be a cleaner
way
> to implement this dispatch than a sequence of 'is' checks. Your call.

Done.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
pkg/analyzer2dart/lib/src/element_converter.dart:48: class ElementY extends
dart2js.Element {
On 2014/09/08 14:07:15, sigurdm wrote:
> Document

Done.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/el...
pkg/analyzer2dart/lib/src/element_converter.dart:337: class
TopLevelFunctionElementY extends ElementY implements dart2js.FunctionElement {
On 2014/09/08 14:07:15, sigurdm wrote:
> long line

Done.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/tr...
File pkg/analyzer2dart/lib/src/tree_shaker.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:26: 
On 2014/09/08 14:07:15, sigurdm wrote:
> Double newline

Done.

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/test/end2e...
File pkg/analyzer2dart/test/end2end_test.dart (right):

https://codereview.chromium.org/548253003/diff/1/pkg/analyzer2dart/test/end2e...
pkg/analyzer2dart/test/end2end_test.dart:123: print('input:\n$input');
On 2014/09/08 14:07:15, sigurdm wrote:
> Debugging prints?

Removed.

[Johnni Winther, 2014-09-09 14:27:10]

Committed patchset #2 manually as 40030 (presubmit successful).