Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: pkg/analyzer2dart/lib/src/tree_shaker.dart

Issue 548253003: First end-to-end capability in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer2dart/lib/src/element_converter.dart ('k') | pkg/analyzer2dart/test/driver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/tree_shaker.dart
diff --git a/pkg/analyzer2dart/lib/src/tree_shaker.dart b/pkg/analyzer2dart/lib/src/tree_shaker.dart
index 03a3bf990c6e1abf770b24823f2bde62bf0ddcec..1b505805788f77603433a3c48f642bbd4f66b5a1 100644
--- a/pkg/analyzer2dart/lib/src/tree_shaker.dart
+++ b/pkg/analyzer2dart/lib/src/tree_shaker.dart
@@ -15,9 +15,14 @@ import 'closed_world.dart';
class TreeShaker {
List<Element> _queue = <Element>[];
Set<Element> _alreadyEnqueued = new HashSet<Element>();
- ClosedWorld _world = new ClosedWorld();
+ ClosedWorld _world;
Set<Selector> _selectors = new HashSet<Selector>();
+ TreeShaker(FunctionElement mainFunction)
+ : _world = new ClosedWorld(mainFunction) {
+ addElement(mainFunction);
+ }
+
void addElement(Element element) {
if (_alreadyEnqueued.add(element)) {
_queue.add(element);
@@ -96,6 +101,19 @@ class TreeShaker {
}
}
+Selector createSelectorFromMethodInvocation(MethodInvocation node) {
+ int arity = 0;
+ List<String> namedArguments = <String>[];
+ for (var x in node.argumentList.arguments) {
+ if (x is NamedExpression) {
+ namedArguments.add(x.name.label.name);
+ } else {
+ arity++;
+ }
+ }
+ return new Selector.call(node.methodName.name, null, arity, namedArguments);
+}
+
class TreeShakingVisitor extends RecursiveAstVisitor {
final TreeShaker treeShaker;
@@ -106,17 +124,7 @@ class TreeShakingVisitor extends RecursiveAstVisitor {
* a non-static method).
*/
void handleMethodCall(MethodInvocation node) {
- int arity = 0;
- List<String> namedArguments = <String>[];
- for (var x in node.argumentList.arguments) {
- if (x is NamedExpression) {
- namedArguments.add(x.name.label.name);
- } else {
- arity++;
- }
- }
- treeShaker.addSelector(
- new Selector.call(node.methodName.name, null, arity, namedArguments));
+ treeShaker.addSelector(createSelectorFromMethodInvocation(node));
}
@override
« no previous file with comments | « pkg/analyzer2dart/lib/src/element_converter.dart ('k') | pkg/analyzer2dart/test/driver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698