Forward heap space argument in String and Integer::New*

Forward heap space argument in String and Integer::New*

BUG=
R=iposva@google.com, vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39874

[jgruber1, 2014-09-04 15:00:50]

jgruber@google.com changed reviewers:
+ fschneider@google.com, iposva@google.com, vegorov@google.com

[Vyacheslav Egorov (Google), 2014-09-04 15:04:11]

lgtm

[Ivan Posva, 2014-09-04 15:37:07]

LGTM -ip

https://codereview.chromium.org/544573003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/544573003/diff/20001/runtime/vm/object.cc#new...
runtime/vm/object.cc:16987: space);
All arguments on a new line, please.

[Vyacheslav Egorov (Google), 2014-09-04 15:37:26]

lgtm

https://codereview.chromium.org/544573003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/544573003/diff/20001/runtime/vm/object.cc#new...
runtime/vm/object.cc:16986: return String::SubString(str, begin_index,
(str.Length() - begin_index),
I usually reformat such call sites as argument-per-line

[jgruber1, 2014-09-04 15:40:57]

https://codereview.chromium.org/544573003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/544573003/diff/20001/runtime/vm/object.cc#new...
runtime/vm/object.cc:16986: return String::SubString(str, begin_index,
(str.Length() - begin_index),
On 2014/09/04 15:37:26, Vyacheslav Egorov (Google) wrote:
> I usually reformat such call sites as argument-per-line

Done.

https://codereview.chromium.org/544573003/diff/20001/runtime/vm/object.cc#new...
runtime/vm/object.cc:16987: space);
On 2014/09/04 15:37:07, Ivan Posva wrote:
> All arguments on a new line, please.

Done.

[jgruber1, 2014-09-04 15:45:54]

Committed patchset #3 (id:40001) manually as 39874 (presubmit successful).