Forward heap space argument in String and Integer::New*

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 15422 matching lines @@
 }
 
 
 RawInteger* Integer::New(int64_t value, Heap::Space space, const bool silent) {
   const bool is_smi = Smi::IsValid(value);
   if (!silent &&
       FLAG_throw_on_javascript_int_overflow &&
       !IsJavascriptInt(value)) {
     const Integer& i = is_smi ?
         Integer::Handle(Smi::New(static_cast<intptr_t>(value))) :
-        Integer::Handle(Mint::New(value));
+        Integer::Handle(Mint::New(value, space));
     ThrowJavascriptIntegerOverflow(i);
   }
   if (is_smi) {
     return Smi::New(static_cast<intptr_t>(value));
   }
   return Mint::New(value, space);
 }
 
 
 RawInteger* Integer::NewFromUint64(uint64_t value, Heap::Space space) {
   if (value > static_cast<uint64_t>(Mint::kMaxValue)) {
     if (FLAG_throw_on_javascript_int_overflow) {
       const Integer &i =
-          Integer::Handle(BigintOperations::NewFromUint64(value));
+          Integer::Handle(BigintOperations::NewFromUint64(value, space));
       ThrowJavascriptIntegerOverflow(i);
     }
-    return BigintOperations::NewFromUint64(value);
+    return BigintOperations::NewFromUint64(value, space);
   } else {
-    return Integer::New(value);
+    return Integer::New(value, space);
   }
 }
 
 
 double Integer::AsDoubleValue() const {
   UNIMPLEMENTED();
   return 0.0;
 }
 
 
@@ skipping 1503 matching lines @@
 }
 
 
 RawString* String::SubString(const String& str,
                              intptr_t begin_index,
                              Heap::Space space) {
   ASSERT(!str.IsNull());
   if (begin_index >= str.Length()) {
     return String::null();
   }
-  return String::SubString(str, begin_index, (str.Length() - begin_index));
+  return String::SubString(str, begin_index, (str.Length() - begin_index),

[Vyacheslav Egorov (Google), 2014/09/04 15:37:26]

I usually reformat such call sites as argument-per-line

[jgruber1, 2014/09/04 15:40:57]

Done.

+                           space);

[Ivan Posva, 2014/09/04 15:37:07]

All arguments on a new line, please.

[jgruber1, 2014/09/04 15:40:57]

Done.

 }
 
 
 RawString* String::SubString(const String& str,
                              intptr_t begin_index,
                              intptr_t length,
                              Heap::Space space) {
   ASSERT(!str.IsNull());
   ASSERT(begin_index >= 0);
   ASSERT(length >= 0);
@@ skipping 2583 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart