Link to stable-errors site from pub-build messages on the command line.

Link to stable-errors site from pub-build messages on the command line.

R=jakemac@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39939

[Siggi Cherem (dart-lang), 2014-09-05 01:07:15]

sigmund@google.com changed reviewers:
+ kathyw@google.com

[Siggi Cherem (dart-lang), 2014-09-05 01:07:16]

This is the code that adds links to the site. It also includes the logic to
autogenerate the site.

Kathy - the index.markdown I sent you in dartlang.org were generated with this
code, the header of that file is defined in _SITE_HEADER in
create_message_details_page.dart

[Kathy Walrath, 2014-09-05 14:59:01]

Some quibbles about wording/formatting, but basically this looks good.

https://codereview.chromium.org/543963002/diff/1/pkg/polymer/tool/create_mess...
File pkg/polymer/tool/create_message_details_page.dart (right):

https://codereview.chromium.org/543963002/diff/1/pkg/polymer/tool/create_mess...
pkg/polymer/tool/create_message_details_page.dart:118: # WARNING - DO NOT EDIT
Let's make this a little more formal and closer to the
header used by the book's generated files (e.g.
https://github.com/dart-lang/www.dartlang.org/blob/master/src/site/docs/dart-...).

How about:

# WARNING: GENERATED FILE. DO NOT EDIT.
#
#   This file was generated automatically from the polymer package.
#   To regenerate this file, from the top directory of the polymer package run:
#
#     dart tool/create_message_details_page.dart -s -o path_to_this_file

https://codereview.chromium.org/543963002/diff/1/pkg/polymer/tool/create_mess...
pkg/polymer/tool/create_message_details_page.dart:144: additional details that
can often help understand or debug error messages.
understand -> you understand

[debugging error messages sounds strange. what do you really mean?]

[Siggi Cherem (dart-lang), 2014-09-05 16:13:15]

Thanks!

https://codereview.chromium.org/543963002/diff/1/pkg/polymer/tool/create_mess...
File pkg/polymer/tool/create_message_details_page.dart (right):

https://codereview.chromium.org/543963002/diff/1/pkg/polymer/tool/create_mess...
pkg/polymer/tool/create_message_details_page.dart:118: # WARNING - DO NOT EDIT
On 2014/09/05 14:59:01, Kathy Walrath wrote:
> Let's make this a little more formal and closer to the
> header used by the book's generated files (e.g.
>
https://github.com/dart-lang/www.dartlang.org/blob/master/src/site/docs/dart-...).
> 
> How about:
> 
> # WARNING: GENERATED FILE. DO NOT EDIT.
> #
> #   This file was generated automatically from the polymer package.
> #   To regenerate this file, from the top directory of the polymer package
run:
> #
> #     dart tool/create_message_details_page.dart -s -o path_to_this_file

Done.

https://codereview.chromium.org/543963002/diff/1/pkg/polymer/tool/create_mess...
pkg/polymer/tool/create_message_details_page.dart:144: additional details that
can often help understand or debug error messages.
On 2014/09/05 14:59:01, Kathy Walrath wrote:
> understand -> you understand
> 
> [debugging error messages sounds strange. what do you really mean?]

how about `figure out how to fix the underlying problem`

[Siggi Cherem (dart-lang), 2014-09-05 18:03:31]

sigmund@google.com changed reviewers:
+ jakemac@google.com
- kathyw@google.com

[Siggi Cherem (dart-lang), 2014-09-05 18:03:31]

oops - I meant to include Jake initially, I seem to have mistakenly included
Kathy twice :)

[Siggi Cherem (dart-lang), 2014-09-05 19:02:39]

thanks to Seth's suggestion, now the script emits markdown only for the site,
and HTML for the internal page we include with pub-serve.

[jakemac, 2014-09-05 22:19:29]

lgtm

https://codereview.chromium.org/543963002/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/messages/build_logger.dart (right):

https://codereview.chromium.org/543963002/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/messages/build_logger.dart:49: this.detailsUri:
'http://goo.gl/5HPeuP'});
Since this isn't part of the polymer package, we probably don't want to hardcode
this link here, but supply it when we create instances (although that will be
annoying).

[Siggi Cherem (dart-lang), 2014-09-05 23:22:09]

On 2014/09/05 22:19:29, jakemac wrote:
> lgtm
> 
>
https://codereview.chromium.org/543963002/diff/40001/pkg/code_transformers/li...
> File pkg/code_transformers/lib/messages/build_logger.dart (right):
> 
>
https://codereview.chromium.org/543963002/diff/40001/pkg/code_transformers/li...
> pkg/code_transformers/lib/messages/build_logger.dart:49: this.detailsUri:
> 'http://goo.gl/5HPeuP'});
> Since this isn't part of the polymer package, we probably don't want to
hardcode
> this link here, but supply it when we create instances (although that will be
> annoying).

Yeah, you are right. Done.

[Siggi Cherem (dart-lang), 2014-09-06 00:09:49]

Committed patchset #5 (id:80001) manually as 39939 (presubmit successful).