Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: pkg/polymer/test/build/common.dart

Issue 543963002: Link to stable-errors site from pub-build messages on the command line. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library polymer.test.build.common; 5 library polymer.test.build.common;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:barback/barback.dart'; 9 import 'package:barback/barback.dart';
10 import 'package:code_transformers/messages/build_logger.dart' 10 import 'package:code_transformers/messages/build_logger.dart'
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 expect(result.succeeded, !errorSeen, reason: "${result.errors}"); 67 expect(result.succeeded, !errorSeen, reason: "${result.errors}");
68 }); 68 });
69 69
70 logSubscription = barback.log.listen((entry) { 70 logSubscription = barback.log.listen((entry) {
71 // Ignore info messages. 71 // Ignore info messages.
72 if (entry.level == LogLevel.INFO || entry.level == LogLevel.FINE) return; 72 if (entry.level == LogLevel.INFO || entry.level == LogLevel.FINE) return;
73 if (entry.level == LogLevel.ERROR) errorSeen = true; 73 if (entry.level == LogLevel.ERROR) errorSeen = true;
74 // We only check messages when an expectation is provided. 74 // We only check messages when an expectation is provided.
75 if (messages == null) return; 75 if (messages == null) return;
76 76
77 var msg = '${entry.level.name.toLowerCase()}: ${entry.message}'; 77 var errorLink = new RegExp(
78 ' See http://goo.gl/5HPeuP#polymer_[0-9]* for details.');
79 var text = entry.message;
80 var newText = text.replaceFirst(errorLink, '');
81 expect(text != newText, isTrue);
82 var msg = '${entry.level.name.toLowerCase()}: ${newText}';
78 var span = entry.span; 83 var span = entry.span;
79 var spanInfo = span == null ? '' : 84 var spanInfo = span == null ? '' :
80 ' (${span.sourceUrl} ${span.start.line} ${span.start.column})'; 85 ' (${span.sourceUrl} ${span.start.line} ${span.start.column})';
81 var index = messagesSeen++; 86 var index = messagesSeen++;
82 expect(messagesSeen, lessThanOrEqualTo(messages.length), 87 expect(messagesSeen, lessThanOrEqualTo(messages.length),
83 reason: 'more messages than expected.\nMessage seen: $msg$spanInfo'); 88 reason: 'more messages than expected.\nMessage seen: $msg$spanInfo');
84 expect('$msg$spanInfo', messages[index]); 89 expect('$msg$spanInfo', messages[index]);
85 }); 90 });
86 } 91 }
87 92
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 248
244 'observe|lib/observe.dart': 249 'observe|lib/observe.dart':
245 'library observe;\n' 250 'library observe;\n'
246 'export "src/metadata.dart";', 251 'export "src/metadata.dart";',
247 252
248 'observe|lib/src/metadata.dart': 253 'observe|lib/src/metadata.dart':
249 'library observe.src.metadata;\n' 254 'library observe.src.metadata;\n'
250 'class ObservableProperty { const ObservableProperty(); }\n' 255 'class ObservableProperty { const ObservableProperty(); }\n'
251 'const observable = const ObservableProperty();\n', 256 'const observable = const ObservableProperty();\n',
252 }; 257 };
OLDNEW
« no previous file with comments | « pkg/polymer/lib/src/build/script_compactor.dart ('k') | pkg/polymer/test/build/linter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698