Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 543393002: improve keyword suggestions (Closed)

Created:
6 years, 3 months ago by danrubel
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -78 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 3 chunks +63 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 9 chunks +182 lines, -59 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 3 months ago (2014-09-06 18:34:22 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-09-08 03:29:46 UTC) #3
danrubel
6 years, 3 months ago (2014-09-08 16:32:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698