improve keyword suggestions

pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.keyword;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 20 matching lines @@
 
 /**
  * A vistor for generating keyword suggestions.
  */
 class _KeywordVisitor extends GeneralizingAstVisitor {
   final DartCompletionRequest request;
 
   _KeywordVisitor(this.request);
 
   @override
+  visitBlock(Block node) {
+    if (_isOffsetAfterNode(node)) {
+      node.parent.accept(this);
+    } else {
+      _addSuggestions(
+          [
+              Keyword.ASSERT,
+              Keyword.CASE,
+              Keyword.CONTINUE,
+              Keyword.DO,
+              Keyword.FACTORY,
+              Keyword.FINAL,
+              Keyword.FOR,
+              Keyword.IF,
+              Keyword.NEW,
+              Keyword.RETHROW,
+              Keyword.RETURN,
+              Keyword.SUPER,
+              Keyword.SWITCH,
+              Keyword.THIS,
+              Keyword.THROW,
+              Keyword.TRY,
+              Keyword.VAR,
+              Keyword.VOID,
+              Keyword.WHILE]);
+    }
+  }
+
+  @override
   visitClassDeclaration(ClassDeclaration node) {
+    // Inside the class declaration { }
+    if (request.offset > node.leftBracket.offset) {
+      _addSuggestions(
+          [
+              Keyword.CONST,
+              Keyword.DYNAMIC,
+              Keyword.FACTORY,
+              Keyword.FINAL,
+              Keyword.GET,
+              Keyword.OPERATOR,
+              Keyword.SET,
+              Keyword.STATIC,
+              Keyword.VAR,
+              Keyword.VOID]);
+      return;
+    }
     // Very simplistic suggestion because analyzer will warn if
     // the extends / with / implements keywords are out of order
     if (node.extendsClause == null) {
       _addSuggestion(Keyword.EXTENDS);
     } else if (node.withClause == null) {
       _addSuggestion(Keyword.WITH);
     }
     if (node.implementsClause == null) {
       _addSuggestion(Keyword.IMPLEMENTS);
     }
@@ skipping 41 matching lines @@
               Keyword.CLASS,
               Keyword.CONST,
               Keyword.FINAL,
               Keyword.TYPEDEF,
               Keyword.VAR]);
     }
   }
 
   @override
   visitNode(AstNode node) {
-    if (request.offset == node.end) {
-      Token token = node.endToken;
-      if (token != null && !token.isSynthetic) {
-        if (token.lexeme == ';' || token.lexeme == '}') {
-          node.parent.accept(this);
-        }
-      }
+    if (_isOffsetAfterNode(node)) {
+      node.parent.accept(this);
     }
   }
 
   visitSimpleIdentifier(SimpleIdentifier node) {
-    AstNode parent =
-        node.getAncestor((n) => n is TopLevelVariableDeclaration);
+    AstNode parent = node.getAncestor((n) => n is TopLevelVariableDeclaration);
     if (parent is TopLevelVariableDeclaration) {
-      if (parent.variables != null && parent.variables.type != null
-          && parent.variables.type.name == node) {
+      if (parent.variables != null &&
+          parent.variables.type != null &&
+          parent.variables.type.name == node) {
         AstNode unit = node.getAncestor((n) => n is CompilationUnit);
         if (unit is CompilationUnit) {
           visitCompilationUnit(unit);
         }
       }
     }
   }
 
   void _addSuggestion(Keyword keyword) {
     String completion = keyword.syntax;
     request.suggestions.add(
         new CompletionSuggestion(
             CompletionSuggestionKind.KEYWORD,
             CompletionRelevance.DEFAULT,
             completion,
             completion.length,
             0,
             false,
             false));
   }
 
   void _addSuggestions(List<Keyword> keywords) {
     keywords.forEach((Keyword keyword) {
       _addSuggestion(keyword);
     });
   }
+
+  bool _isOffsetAfterNode(AstNode node) {
+    if (request.offset == node.end) {
+      Token token = node.endToken;
+      if (token != null && !token.isSynthetic) {
+        if (token.lexeme == ';' || token.lexeme == '}') {
+          return true;
+        }
+      }
+    }
+    return false;
+  }
 }