Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 542473003: Teach the Observatory about MirrorReferences. (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Teach the Observatory about MirrorReferences. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39883

Patch Set 1 #

Patch Set 2 : added mirror_references_test.dart #

Patch Set 3 : build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -64 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 2 3 chunks +25 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 2 3 chunks +25 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/boot.js View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/polymer.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log View 1 2 1 chunk +13 lines, -16 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log View 1 2 1 chunk +23 lines, -32 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.html View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart View 2 chunks +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 4 chunks +4 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/test/mirror_references_test.dart View 1 1 chunk +47 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
6 years, 3 months ago (2014-09-04 00:52:37 UTC) #2
Cutch
lgtm after adding service test.
6 years, 3 months ago (2014-09-04 15:25:25 UTC) #3
rmacnak
Added
6 years, 3 months ago (2014-09-04 19:54:15 UTC) #4
rmacnak
6 years, 3 months ago (2014-09-04 19:55:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 39883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698