Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/service/object.dart

Issue 542473003: Teach the Observatory about MirrorReferences. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/service/object.dart
diff --git a/runtime/bin/vmservice/observatory/lib/src/service/object.dart b/runtime/bin/vmservice/observatory/lib/src/service/object.dart
index 2b35a99eedebd11dd9691dea8019d1ebb2f88a88..8ed63c4354bba701984f36fa391ac925be8c25e9 100644
--- a/runtime/bin/vmservice/observatory/lib/src/service/object.dart
+++ b/runtime/bin/vmservice/observatory/lib/src/service/object.dart
@@ -46,6 +46,7 @@ abstract class ServiceObject extends Observable {
bool get isInstance => vmType == 'Instance';
bool get isInt => vmType == 'Smi' || vmType == 'Mint' || vmType == 'Bigint';
bool get isList => vmType == 'GrowableObjectArray' || vmType == 'Array';
+ bool get isMirrorReference => vmType == 'MirrorReference';
bool get isNull => vmType == 'Null';
bool get isSentinel => vmType == 'Sentinel';
bool get isString => vmType == 'String';
@@ -115,6 +116,7 @@ abstract class ServiceObject extends Observable {
case 'GrowableObjectArray':
case 'Instance':
case 'Mint':
+ case 'MirrorReference':
case 'Null':
case 'Sentinel': // TODO(rmacnak): Separate this out.
case 'Smi':
@@ -1487,6 +1489,7 @@ class Instance extends ServiceObject {
@observable var nativeFields;
@observable var elements;
@observable var userName;
+ @observable var referent; // If a MirrorReference.
bool get isClosure => closureFunc != null;
@@ -1513,6 +1516,7 @@ class Instance extends ServiceObject {
elements = map['elements'];
typeClass = map['type_class'];
userName = map['user_name'];
+ referent = map['referent'];
// We are fully loaded.
_loaded = true;

Powered by Google App Engine
This is Rietveld 408576698