Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 539573003: Adds support for building arm64 Android. (Closed)

Created:
6 years, 3 months ago by zra
Modified:
6 years, 3 months ago
Reviewers:
ricow1, regis, Ivan Posva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds support for building arm64 Android. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=39844

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -29 lines) Patch
M runtime/bin/dbg_connection_android.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/third_party/double-conversion/src/double-conversion.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download
M runtime/vm/cpu_arm64.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M runtime/vm/cpuinfo_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_android.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/signal_handler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/signal_handler_android.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M tools/android_link.py View 5 chunks +15 lines, -4 lines 0 comments Download
M tools/build.py View 4 chunks +6 lines, -2 lines 0 comments Download
M tools/gyp/configurations.gypi View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/gyp/configurations_android.gypi View 3 chunks +54 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
https://codereview.chromium.org/539573003/diff/1/runtime/third_party/double-conversion/src/double-conversion.cc File runtime/third_party/double-conversion/src/double-conversion.cc (right): https://codereview.chromium.org/539573003/diff/1/runtime/third_party/double-conversion/src/double-conversion.cc#newcode580 runtime/third_party/double-conversion/src/double-conversion.cc:580: const double double_number = static_cast<double>(number); This change is to ...
6 years, 3 months ago (2014-09-03 17:03:07 UTC) #2
regis
LGTM
6 years, 3 months ago (2014-09-03 17:21:25 UTC) #3
zra
6 years, 3 months ago (2014-09-03 23:32:04 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r39844 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698