Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: runtime/vm/cpu_arm64.cc

Issue 539573003: Adds support for building arm64 Android. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/third_party/double-conversion/src/double-conversion.cc ('k') | runtime/vm/cpuinfo_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/cpu_arm64.cc
===================================================================
--- runtime/vm/cpu_arm64.cc (revision 39843)
+++ runtime/vm/cpu_arm64.cc (working copy)
@@ -24,17 +24,13 @@
return;
}
- // ARM recommends using the gcc intrinsic __clear_cache on Linux, and the
- // library call cacheflush from unistd.h on Android:
+ // ARM recommends using the gcc intrinsic __clear_cache on Linux and Android.
// blogs.arm.com/software-enablement/141-caches-and-self-modifying-code/
- #if defined(__linux__) && !defined(ANDROID)
+ #if defined(__linux__) || defined(ANDROID)
extern void __clear_cache(char*, char*);
char* beg = reinterpret_cast<char*>(start);
char* end = reinterpret_cast<char*>(start + size);
::__clear_cache(beg, end);
- #elif defined(ANDROID)
- // TODO(zra): Verify that this is correct for arm64 in addition to arm.
- cacheflush(start, start + size, 0);
#else
#error FlushICache only tested/supported on Linux and Android
#endif
« no previous file with comments | « runtime/third_party/double-conversion/src/double-conversion.cc ('k') | runtime/vm/cpuinfo_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698