Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 535333003: Clarify some of the analysis server errors. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Clarify some of the analysis server errors. The errors GET_ERRORS_ERROR, UNANLYZED_PRIORITY_FILES, and UNSUPPORTED_FEATURE exist for legacy reasons and should be removed soon. The error SERVER_ALREADY_STARTED exists for future expansion and is not yet used. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -10 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestErrorCode.java View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 3 chunks +18 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 3 chunks +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 3 chunks +23 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-03 20:01:19 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-03 20:23:17 UTC) #3
Paul Berry
6 years, 3 months ago (2014-09-03 20:36:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698