|
|
Fix error handling in analysis.getError.
Analysis.getError now has the following behaviors:
- If the file in question does not exist, or is not subject to
analysis, a new error called GET_ERRORS_INVALID_FILE is generated.
- If the server's internal state (the set of active analysis contexts)
changes while the query is in process, the query is transparently
restarted; the client no longer receives a GET_ERRORS_ERROR error.
R=scheglov@google.com
Committed: https://code.google.com/p/dart/source/detail?r=39871
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+143 lines, -96 lines) |
Patch |
 |
M |
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestErrorCode.java
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/doc/api.html
|
View
|
|
2 chunks |
+11 lines, -8 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/analysis_server.dart
|
View
|
|
8 chunks |
+53 lines, -27 lines |
2 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/domain_analysis.dart
|
View
|
|
2 chunks |
+28 lines, -18 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/generated_protocol.dart
|
View
|
|
3 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/operation/operation_analysis.dart
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/lib/src/protocol.dart
|
View
|
|
1 chunk |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/analysis/get_errors_test.dart
|
View
|
|
4 chunks |
+13 lines, -12 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/integration/integration_test_methods.dart
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/test/integration/protocol_matchers.dart
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/analysis_server/tool/spec/spec_input.html
|
View
|
|
2 chunks |
+11 lines, -9 lines |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|