Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 532403002: Fix error handling in analysis.getError. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix error handling in analysis.getError. Analysis.getError now has the following behaviors: - If the file in question does not exist, or is not subject to analysis, a new error called GET_ERRORS_INVALID_FILE is generated. - If the server's internal state (the set of active analysis contexts) changes while the query is in process, the query is transparently restarted; the client no longer receives a GET_ERRORS_ERROR error. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39871

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -96 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestErrorCode.java View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 2 chunks +11 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 8 chunks +53 lines, -27 lines 2 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +28 lines, -18 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 3 chunks +6 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 4 chunks +13 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-03 21:03:49 UTC) #2
scheglov
LGTM https://codereview.chromium.org/532403002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/532403002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode663 pkg/analysis_server/lib/src/analysis_server.dart:663: Source source = getSource(file); // prepare Source ...just ...
6 years, 3 months ago (2014-09-03 21:24:29 UTC) #3
Paul Berry
https://codereview.chromium.org/532403002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/532403002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode663 pkg/analysis_server/lib/src/analysis_server.dart:663: Source source = getSource(file); On 2014/09/03 21:24:29, scheglov wrote: ...
6 years, 3 months ago (2014-09-04 14:34:08 UTC) #4
Paul Berry
6 years, 3 months ago (2014-09-04 14:34:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 39871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698