Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: pkg/analysis_server/tool/spec/spec_input.html

Issue 532403002: Fix error handling in analysis.getError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/tool/spec/spec_input.html
diff --git a/pkg/analysis_server/tool/spec/spec_input.html b/pkg/analysis_server/tool/spec/spec_input.html
index 11f90e2b7b7e71eec60a4aec0126780804e61f13..1fcbcb95325dd2d50b26febe00f537bc206558ce 100644
--- a/pkg/analysis_server/tool/spec/spec_input.html
+++ b/pkg/analysis_server/tool/spec/spec_input.html
@@ -274,6 +274,13 @@
should use the information provided by the 'analysis.errors'
notification.
</p>
+ <p>
+ If a request is made for a file which does not exist, or
+ which is not currently subject to analysis (e.g. because it
+ is not associated with any analysis root specified to
+ analysis.setAnalysisRoots), an error of type
+ GET_ERRORS_INVALID_FILE will be generated.
+ </p>
<params>
<field name="file">
<ref>FilePath</ref>
@@ -2586,17 +2593,12 @@
</p>
<enum>
<value>
- <code>GET_ERRORS_ERROR</code>
- <p>
- An error occurred during the processing of an
- "analysis.getErrors" request.
- </p>
+ <code>GET_ERRORS_INVALID_FILE</code>
<p>
- This is a legacy error; it will be removed before the
- API reaches version 1.0.
+ An "analysis.getErrors" request specified a FilePath
+ which does not match a file currently subject to
+ analysis.
</p>
- <!-- TODO(paulberry): remove this error and the code that
- generates it. -->
</value>
<value>
<code>INVALID_PARAMETER</code>

Powered by Google App Engine
This is Rietveld 408576698