Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 532063002: Teach the Observatory about Contexts. Factor out object graph information from the instance view. (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Teach the Observatory about Contexts. Factor out object graph information from the instance view. Address various issues with mismatched tags and type errors. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39845

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : elements -> variables #

Patch Set 7 : add contexts_test.dart #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6627 lines, -3921 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 2 3 4 5 6 7 15 chunks +1355 lines, -446 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html._data View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 5 6 7 436 chunks +1548 lines, -1350 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 2 3 4 5 6 7 15 chunks +1355 lines, -446 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html._data View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 5 6 7 436 chunks +1548 lines, -1350 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/context_ref.html View 1 2 3 4 5 6 7 1 chunk +33 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/context_view.html View 1 2 3 4 5 6 7 1 chunk +69 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/eval_box.html View 1 2 3 4 5 6 7 4 chunks +8 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 3 4 5 6 7 8 chunks +34 lines, -93 lines 0 comments Download
A runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/object_common.html View 1 2 3 4 5 6 7 1 chunk +100 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/service_view.html View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/boot.js View 1 2 3 4 5 6 7 1 chunk +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/polymer.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log View 1 2 3 4 5 6 7 1 chunk +13 lines, -16 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log View 1 2 3 4 5 6 7 1 chunk +23 lines, -32 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/elements.dart View 1 2 3 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/class_view.html View 1 2 5 6 7 1 chunk +1 line, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/context_ref.dart View 1 2 3 5 6 7 1 chunk +33 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/context_ref.html View 1 2 3 4 5 6 7 1 chunk +33 lines, -0 lines 0 comments Download
A + runtime/bin/vmservice/observatory/lib/src/elements/context_view.dart View 1 5 6 7 1 chunk +9 lines, -8 lines 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/context_view.html View 1 2 3 4 5 6 7 1 chunk +69 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/eval_box.html View 1 5 6 7 4 chunks +8 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart View 1 2 5 6 7 2 chunks +7 lines, -8 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart View 1 2 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html View 1 2 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.dart View 1 2 3 5 6 7 2 chunks +2 lines, -27 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.html View 1 2 5 6 7 8 chunks +34 lines, -93 lines 0 comments Download
A + runtime/bin/vmservice/observatory/lib/src/elements/object_common.dart View 1 2 5 6 7 1 chunk +10 lines, -15 lines 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/object_common.html View 1 2 5 6 7 1 chunk +100 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart View 1 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart View 1 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_view.html View 1 2 3 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 2 3 4 5 6 7 7 chunks +50 lines, -5 lines 0 comments Download
A runtime/bin/vmservice/observatory/test/contexts_test.dart View 1 2 3 4 5 6 7 1 chunk +119 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
rmacnak
6 years, 3 months ago (2014-09-03 21:19:12 UTC) #2
Cutch
https://codereview.chromium.org/532063002/diff/80001/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart (right): https://codereview.chromium.org/532063002/diff/80001/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart#newcode78 runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart:78: ServiceRefElement element = new Element.tag('context-ref'); Why not "var element" ...
6 years, 3 months ago (2014-09-03 22:06:49 UTC) #3
rmacnak
https://codereview.chromium.org/532063002/diff/80001/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart File runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart (right): https://codereview.chromium.org/532063002/diff/80001/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart#newcode78 runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart:78: ServiceRefElement element = new Element.tag('context-ref'); On 2014/09/03 22:06:49, Cutch ...
6 years, 3 months ago (2014-09-03 22:44:06 UTC) #4
Cutch
lgtm after adding service_tests for context JSON printing.
6 years, 3 months ago (2014-09-03 23:02:31 UTC) #5
rmacnak
Added contexts_test.dart, PTAL
6 years, 3 months ago (2014-09-04 00:13:07 UTC) #6
Cutch
lgtm
6 years, 3 months ago (2014-09-04 00:14:03 UTC) #7
rmacnak
6 years, 3 months ago (2014-09-04 00:28:12 UTC) #8
Message was sent while issue was closed. 
Committed patchset #8 (id:110001) manually as 39845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698