Issue 531153002: Clarify type names in analysis server API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 531153002: Clarify type names in analysis server API. (Closed)

Created:
6 years, 3 months ago by Paul Berry

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clarify type names in analysis server API. The following types are renamed: - ErrorFixes -> AnalysisErrorFixes - ErrorSeverity -> AnalysisErrorSeverity - ErrorType -> AnalysisErrorType This clarifies that the types have to do with the errors/warnings/hints generated by the analysis of user code, as opposed to analysis server protocol errors. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39770

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+400 lines, -608 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetFixesConsumer.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisErrorFixes.java	View	3 chunks	+11 lines, -11 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisErrorSeverity.java	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisErrorType.java	View	1 chunk	+1 line, -1 line	0 comments	Download
D	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorFixes.java	View	1 chunk	+0 lines, -138 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorSeverity.java	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorType.java	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/FixesProcessor.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/processor/AnalysisErrorImplTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor_NEW.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor_OLD.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	5 chunks	+32 lines, -32 lines	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	10 chunks	+210 lines, -210 lines	0 comments	Download
M	pkg/analysis_server/lib/src/protocol.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/get_errors_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_errors_test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/edit/fixes_test.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	5 chunks	+56 lines, -56 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/codegen_dart_protocol.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	4 chunks	+46 lines, -46 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

6 years, 3 months ago (2014-09-02 19:54:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 39770 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages