editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java - Issue 531153002: Clarify type names in analysis server API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java

Issue 531153002: Clarify type names in analysis server API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/processor/AnalysisErrorImplTest.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor_NEW.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java

index 97d9c7036fc83ff0a5a1a3fb206d1b7e3d61b4dd..2d60833c4cb28114c0e813bf8e3fc505aaf9bd56 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java

@@ -15,7 +15,7 @@ package com.google.dart.tools.core.internal.builder;

import com.google.dart.engine.utilities.source.LineInfo;

import com.google.dart.server.generated.types.AnalysisError;

-import com.google.dart.server.generated.types.ErrorSeverity;

+import com.google.dart.server.generated.types.AnalysisErrorSeverity;

import com.google.dart.server.generated.types.Location;

import com.google.dart.tools.core.DartCore;

@@ -85,9 +85,9 @@ public class AnalysisMarkerManager_NEW {

// Show errors first, then warnings, followed by everything else

// while limiting the total number of markers added to MAX_ERROR_COUNT

int errorCount = 0;

- errorCount = showErrors(errorCount, ErrorSeverity.ERROR, IMarker.SEVERITY_ERROR);

- errorCount = showErrors(errorCount, ErrorSeverity.WARNING, IMarker.SEVERITY_WARNING);

- errorCount = showErrors(errorCount, ErrorSeverity.INFO, IMarker.SEVERITY_INFO);

+ errorCount = showErrors(errorCount, AnalysisErrorSeverity.ERROR, IMarker.SEVERITY_ERROR);

+ errorCount = showErrors(errorCount, AnalysisErrorSeverity.WARNING, IMarker.SEVERITY_WARNING);

+ errorCount = showErrors(errorCount, AnalysisErrorSeverity.INFO, IMarker.SEVERITY_INFO);

if (errorCount >= MAX_ERROR_COUNT) {

IMarker marker = resource.createMarker(DartCore.DART_PROBLEM_MARKER_TYPE);